Fix memory leak #224
Merged
Fix memory leak #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me test this first
…On Mon, May 22, 2023, 6:29 AM Adam Eisenreich ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#224
Commit Summary
- ce84bf5
<ce84bf5>
Fix: Memory leak on every change of source
File Changes
(1 file <https://github.com/intbot/ng2-pdfjs-viewer/pull/224/files>)
- *M* lib/src/ng2-pdfjs-viewer.component.ts
<https://github.com/intbot/ng2-pdfjs-viewer/pull/224/files#diff-29c27c9eab17983a95c97e2684e13c13be4fc827f04d33e0e5d65c65fedc8774>
(22)
Patch Links:
- https://github.com/intbot/ng2-pdfjs-viewer/pull/224.patch
- https://github.com/intbot/ng2-pdfjs-viewer/pull/224.diff
—
Reply to this email directly, view it on GitHub
<#224>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEL3UNRCCXUHDFMTYPDQLO3XHM5Z7ANCNFSM6AAAAAAYKHOTIA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Just rebased. This fixes the |
|
@Akxe, You are super quick. Appreciate it. Merging |
|
Looks like there is still a leak when the component is destroyed, right? |
|
This PR fixed one. Did you find any other? |
|
I just noticed that the added |
|
Well... It must have gotten removed when rebasing the PR on the new master... I am out of the office. Would you create the mentioned fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.